Cleanup NodeBuilder #1380
Merged
Cleanup NodeBuilder #1380
+715
−823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
mk/NodeBuilderMetadata
branch
from
3e06ddd to
2d1465f
Compare
|
The remaining failing tests are in the python frontend. Since we are re-writing this anyway, we are not fixing this in the old frontend, but are blocked by #1282, which we will merge soon. |
oxisto
force-pushed
the
mk/NodeBuilderMetadata
branch
from
9760b79 to
b351f2a
Compare
oxisto
force-pushed
the
mk/NodeBuilderMetadata
branch
from
b351f2a to
ca3d21c
Compare
oxisto
approved these changes
Nov 30, 2023
oxisto
force-pushed
the
mk/NodeBuilderMetadata
branch
from
c0f4cba to
20cbffe
Compare
oxisto
force-pushed
the
mk/NodeBuilderMetadata
branch
from
20cbffe to
8d27fe6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
pushed a commit
that referenced
this pull request
Dec 30, 2023
oxisto
pushed a commit
that referenced
this pull request
Dec 30, 2023
oxisto
pushed a commit
that referenced
this pull request
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeBuilder uses
rawNodeto apply metadata. Optional parameterslocationandcodeare not in the rest of the codebase used and removed to cleanup the NodeBuilder code.