Make custom pass list option independent of default passes #1418
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckto
force-pushed
the
cpg-neo4j-update-custom-pass-list
branch
from
e90e315 to
8cdd949
Compare
oxisto
force-pushed
the
cpg-neo4j-update-custom-pass-list
branch
from
8cdd949 to
c39abf6
Compare
oxisto
approved these changes
Jan 25, 2024
peckto
force-pushed
the
cpg-neo4j-update-custom-pass-list
branch
from
c39abf6 to
877c568
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the
--custom-pass-listoption was combined with the--no-default-passesoption.Re-thinking about it, this seems an unnecessary limitation.
When using the custom pass list option together with the default passes, passes, which are not in the default list, can be added easily (e.g.
ProgramDependenceGraphPass).