-
Notifications
You must be signed in to change notification settings - Fork 73
Fixes to type propagation of arithmetic expressions #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+150
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
reviewed
Mar 7, 2024
cpg-language-java/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/java/ExpressionHandler.kt
Outdated
Show resolved
Hide resolved
...uage-java/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/java/JavaLanguageFrontendTest.kt
Outdated
Show resolved
Hide resolved
oxisto
reviewed
Mar 8, 2024
...uage-java/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/java/JavaLanguageFrontendTest.kt
Outdated
Show resolved
Hide resolved
oxisto
approved these changes
Mar 8, 2024
konradweiss
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerning #1444 (and more small problems came up when dealing with it):
BinaryOperator
s with the operator code%
,||
,&&
, and>>>
are now typed correctly. I could verify that the propagation is valid for the first three in all supported languages, and for>>>
, the left operand type is used, like with the other bit shift operators.f
orF
, now get the FloatingPointType for floats instead of doubles. The JavaParser library does not differentiate between float and double literals, so a manual check is necessary.arithmeticOpTypePropagation
, as BooleanType is a subclass of NumericType.propagateTypeOfBinaryOperation
a bit, asarithmeticOpTypePropagation
can already handle invalid cases