Add members, methods and imports to EnumDeclarations #1450
Merged
+226
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradweiss
requested changes
Mar 11, 2024
cpg-language-java/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/java/DeclarationHandler.kt
Outdated
Show resolved
Hide resolved
cpg-language-java/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/java/DeclarationHandler.kt
Outdated
Show resolved
Hide resolved
cpg-language-java/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/java/DeclarationHandler.kt
Outdated
Show resolved
Hide resolved
konradweiss
approved these changes
Mar 13, 2024
|
Sorry, my IDE reformatted the code back upon committing. And the commit title was not meant to refer to that issue. |
It confused me a bit ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerning #1445:
EnumDeclarations now get assigned their class members, just likeRecordDeclarations.ImportResolvercorrectly identifies entries and other members ofEnumDeclarations that are imported.ImportDeclarations, separating them afterwards byisStatic(a comment indicated that something similar was done earlier and then undone)EnumDeclarations andRecordDeclarations and refactored out common parts into separate methods