Fixing record inference and making SymbolResolver deterministic again
#1476
+131
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the type that is forwarded to the inference type. Previously any type (including a pointer type) was forwarded to `inferRecordDeclaration`. This was not working for pointer types. Now instead, the `root` type is used, which points to the element type in case of (chained) pointer types. Also changed an error message in the scope manager to a warning and improved logging in the inference system slightly. Fixes #1475
oxisto
changed the title
SymbolResolver deterministic again
oxisto
changed the title
SymbolResolver deterministic againSymbolResolver deterministic again
KuechA
approved these changes
Mar 27, 2024
konradweiss
approved these changes
Mar 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type that is forwarded to the inference type. Previously any type (including a pointer type) was forwarded to
inferRecordDeclaration. This was not working for pointer types. Now instead, theroottype is used, which points to the element type in case of (chained) pointer types. Also changed an error message in the scope manager to a warning and improved logging in the inference system slightly.This also makes the behaviour of the
SymbolResolverdeterministic again, this was caused by a unfortunate combination oftoSetcalls.Fixes #1475