-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to use a release-independent repository for CDT #1522
base: main
Are you sure you want to change the base?
Conversation
This is some rather ugly workaround in our ivy repository layout, but it should work for all future releases.
55a9887
to
1f752b7
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a description where the benefits (or drawbacks) are compared to the previous way we included the CDT? I only have a slight idea that we will have to update version in the new repo but users are now always getting the one we specify there.
Previously, users needed to adjust their "repository" in their gradle configuration if we updated CDT because the repository URL contained the CDT version (see https://github.com/Fraunhofer-AISEC/codyze/pull/791/files). We only reserved this for major versions of the CPG for now With this new approach the repository URL stays the same and we can update the CDT version also in a minor version. The drawback is, that is a little bit hacky because we have now a URL path in the name of the dependency, but gradle doesn't seem to mind 🤷 I don't know if maven central could potentially have a problem with it. |
We should probably reserve this for release v9 |
This is some rather ugly workaround in our ivy repository layout, but it should work for all future releases.