Adding some nodes to the AST subtree that prob should be there #1550
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
reviewed
Apr 29, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/declarations/DeclarationSequence.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/declarations/EnumConstantDeclaration.kt
Show resolved
Hide resolved
...re/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/declarations/FunctionTemplateDeclaration.kt
Show resolved
Hide resolved
oxisto
approved these changes
May 1, 2024
…should not, if thy are already part of the AST at some other place.
…nly as an ephemeral construct that does not make it to persistency or a pass that uses the annotation
konradweiss
force-pushed
the
bugfix/ast-tree
branch
from
88d645d to
d8f5f8b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when the elements in a
RangedExpressionwhere not properly returned bySubgraphWalker.flattenASTwhich created issues together with other methods. I went over all nodes and tried to identify fields that should also have the@ASTannotation.They should not, if they are already part of the AST in some other subtree and are only referenced here.