Filter eogstarters which do not start the eog #1560
Merged
+103
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
approved these changes
May 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
EOGStarterHolders to identify possible start nodes of the EOG. However, they might also be located in the middle of an existing EOG which means that some visitors would visit them multiple times and potentially even out-of-order. One example is theSymbolResolverwhich also led to #1459. We check that we only start the EOG-iteration/walking for nodes which are not in another EOG (i.e., we only visit nodes which actually serve as an entry-point).Fixes #1459