Cleanup of SubgraphWalker
#1571
Merged
+58
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuechA
approved these changes
Jun 3, 2024
This PR fixes a rather intricate bug in the subgraph walker that made the symbol resolver not resolve / "reach" all the necessary nodes. I took this opportunity to remove some legacy code from the class and also clean it up a lot.
oxisto
force-pushed
the
cleanup-subgraph-walker
branch
from
d935f62 to
86bd62c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a rather intricate bug in the subgraph walker that made the symbol resolver not resolve / "reach" all the necessary nodes. I took this opportunity to remove some legacy code from the class and also clean it up a lot.
In theory this should also make it a little bit faster because we do a little less stack pushing / peeking than before, but this is probably not noticeable.