Skip to content

Bugfix/annotations and Missing Enums #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2024
Merged

Bugfix/annotations and Missing Enums #1585

merged 3 commits into from
Jun 10, 2024
+4 −1

Conversation

konradweiss
Copy link
Collaborator

@konradweiss konradweiss commented Jun 9, 2024 •
edited
Loading

This fixes two issues:

  • An unnecessary cast caused an Exception when restricting what type could be in a simple annotation member.
  • The conversion from an instanceOf to a kotlin when construct disabled processing of Enums in Java.

@konradweiss konradweiss changed the title Bugfix/annotations simple member Bugfix/annotations and Missing Enums Jun 9, 2024
@konradweiss
Reenabling ENums inside of records
Loading
Loading status checks…
815333f
@konradweiss konradweiss marked this pull request as ready for review June 9, 2024 21:22
@konradweiss konradweiss requested review from oxisto and KuechA as code owners June 9, 2024 21:22
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradweiss konradweiss merged commit e82cf1d into main Jun 10, 2024
3 checks passed
@konradweiss konradweiss deleted the bugfix/annotations-simple-member branch June 10, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxisto oxisto

@KuechA KuechA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@konradweiss @oxisto