workaround for error: FA³ST Service not compilable with Java16+ #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t variables which is no longer allowed anymore from JDK 16 (Caused problems with SystemLambda.WithEnvironmentVariables.execute() in AppTest.java)
mjacoby
requested changes
Jun 27, 2022
starter/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>2.22.2</version> |
There was a problem hiding this comment.
introduce maven property holding version information (name should be maven.plugin.surefire.version) and valu should be latest version of the plugin.
starter/pom.xml
Outdated
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <argLine>--add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED</argLine> |
There was a problem hiding this comment.
Is this solution backward-compatible, i.e. does this cause any issues when used with older JREs?
Also this seems to be overriding the command-line parameters passed via -Dxxx=yyy (used here
Is there any other way to do this?
There was a problem hiding this comment.
it is backwards compatible (tested with java 11) but
I realise that my suggestion is not a proper solution.
Since the problem is caused by the library performing non-java 16 compliant actions, I would have a look if there is another way to perform the corresponding test cases.
…vironment variables which is no longer allowed anymore from JDK 16" This reverts commit 8ce5f67.
…mpatibility problems with java 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add maven-surefire-plugin with arguments to allow changing environment variables which is no longer allowed from JDK 16
(Caused problems with SystemLambda.WithEnvironmentVariables.execute() in AppTest.java)
Known Problem in com.github.stefanbirkner.systemlambda.SystemLambda: stefanbirkner/system-lambda#23