Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to the grunt build to switch between
dev
andprod
mode.The build is changed to compress and optimize the less and js bundles, buts adds inline source maps to the files in dev mode.
File size comparison after including #1350, #1351, and #1352 comparing to latest release:
Note, that css only have sourcemaps in the new dev build.
I tried to create source maps as separate files to be loaded when required, but couldn't get it to work correctly with less. (Source map path has to adapted to future server serving location.)
Running the browserify optimizations (from the
tinyify
plugin) increases the time that task takes significantly. For development, we might want to look into better watch-options, for examplewatchify
, which in turn might be difficult to integrate into the current grunt workflow, especially since we are not using any grunt-browserify. (Longer term, a shift from grunt to npm scripts might be the best way. It already seems to be the way the community is going.)@campersau @jung-kim @wmertens Would love some feedback on this.