Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warning message to be grammatically correct #1383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update warning message to be grammatically correct #1383

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2020

I'm unsure what the specific intent of this message is. Is it specifically saying "you may be reversing history, which could lose commits", or "you may be rewriting history, which is bad practice", both, or something else? I ask, because it might be helpful to add a link to some git tutorial page which explains why it's bad or what could go wrong, or to make the message more specific.

nathanwoodcodes added 2 commits June 13, 2020 05:41
I'm unsure what the specific intent of this message is. Is it specifically saying "you may be reversing history, which could loose commits", or "you may be rewriting history, which is bad practice", both, or something else?
@ghost ghost changed the title Update warning message to be gramatically correct Update warning message to be grammatically correct Jun 13, 2020
The irony of this does not escape me.
@campersau
Copy link
Collaborator

It is more like you may be reversing history, which could lose commits but I personally think the message is fine since it does not reverse anything, you can still go back to the future if there was another ref. It is just moving a ref to another commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant