Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssh-add -K #1420

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add ssh-add -K #1420

wants to merge 3 commits into from

Conversation

jung-kim
Copy link
Collaborator

@jung-kim jung-kim commented Sep 4, 2020

No description provided.

README.md Outdated Show resolved Hide resolved
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
-----------------
Ungit does run git commands in background and authentication will be asked continously when working with private repos. Easiest way to prevent this is to set up ssh authorization and cache it.

1. Follow github's [instruction](https://docs.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Correctly capitalize GitHub
  2. Remove language from URL to default to user language
Suggested change
1. Follow github's [instruction](https://docs.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent)
1. Follow GitHub's [instructions](https://docs.github.com/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent)

Ungit does run git commands in background and authentication will be asked continously when working with private repos. Easiest way to prevent this is to set up ssh authorization and cache it.

1. Follow github's [instruction](https://docs.github.com/en/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent)
2. Ensure `ssh-add -K ~/.ssh/id_rsa` or with whatever ssh key file name is executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not covered by the instructions linked above?

Additionally, it seems that the -K option only applies to (most) macs:
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is covered, but not always followed, which is why I would like to ensure.

As far as -K being only for mac only I didn't know about. Maybe it be better to change to more targeted ssh-add

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jan Pilzer <jan.pilzer@gmx.de>

SSH Authentication
-----------------
Ungit does run git commands in background and authentication will be asked continously when working with private repos. Easiest way to prevent this is to set up ssh authorization and cache it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix typo.
  2. "authorization" -> "authentication" (see above
Suggested change
Ungit does run git commands in background and authentication will be asked continously when working with private repos. Easiest way to prevent this is to set up ssh authorization and cache it.
Ungit does run git commands in background and authentication will be asked continuously when working with private repos. Easiest way to prevent this is to set up ssh authentication and cache it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants