Improvements from nodegit branch #1527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmertens
force-pushed
the
fixes
branch
4 times, most recently
from
cb2d008
to
e23a383
Compare
By wrapping the entire handler, synchronous errors are also reported
I've never seen it in action and when you use skip it shows all the time
It's useful for context
|
FYI the tests fail because gravatar returns 404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved some generic fixes down on my branch and I think these can be considered for inclusion in master. I added the more contentious ones near the top so I can just move the HEAD :-)