Draft: Draft_SetStyle new Material handling #13914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The short answer is no, I don't, but I'll look into it. The property editor was modified by @wwmayer so he may know. |
|
I guess the order of the colors is the same as of the documentation of the SoMaterial class: https://www.coin3d.org/Coin/html/classSoMaterial.html |
Also removed the ret_default argument.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #13657.
To accommodate the new properties the task panel now has a tabbed interface. The properties on the Annotation tab have been reordered to match the related Preference page.
The order of the Shape appearance properties matches the related Preference page as well. I do not understand why these properties have have different order in the Properties view (if you expand the ShapeAppearance node). @davesrocketshop Do you know the reason for this?