Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material: Appearance and Material inspectors #13967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davesrocketshop
Copy link
Contributor

Dialogs to view the Appearance and Material properties of an object

These inspectors are intended to be used when debugging Appearance and Material issues in a model.

The Appearance inspector displays the appearance properties of an object. This will be more useful once PR 13792 is merged which migrates parts to use ShapeAppearance instead of DiffuseColor. This shows each of the appearance properties per face for the object.

The Material inspector shows the material, models, and properties assigned to a model. It displays useful debugging information such as the UUID and file paths associated with eacch of the items. This is useful when finding and resolving model conflicts.

@github-actions github-actions bot added WB Part Design Related to the Part Design Workbench WB Part Related to the Part Workbench Materials Materials related labels May 12, 2024
@sliptonic
Copy link
Member

I built this and it works to provide new functionality for inspecting materials. It's good for debugging but the UI/UX is rough. Also, I'm not sure if placing the commmand in both the Part and Part Designs menu is the right place.
I suggest @obelisk79 and DWG weigh in.
One easy fix would be to allow resizing the panel.
Also, copying the contents to the clipboard would be nice.

image

@davesrocketshop
Copy link
Contributor Author

Is there a mechanism to allow for resizing this panel? I'm not aware of any currently, but I certainly won't claim to know everything. Open to suggestions because I'd really like to be able to do this.

Copy to clipboard or save to file are also good, but it would require some work. I would consider this MVP not finished feature.

As for where it belongs, it should probably be part of the Part WB at the very least, more so when the next materials PR gets merged. Part Design was just for convenience. These are easy changes... just requires consensus

@davesrocketshop
Copy link
Contributor Author

@sliptonic Option to copy to clipboard has been added

Dialogs to view the Appearance and Material properties of an object

These inspectors are intended to be used when debugging Appearance and
Material issues in a model.

The Appearance inspector displays the appearance properties of an
object. This will be more useful once PR 13792 is merged which migrates
parts to use ShapeAppearance instead of DiffuseColor. This shows each
of the appearance properties per face for the object.

The Material inspector shows the material, models, and properties
assigned to a model. It displays useful debugging information such as
the UUID and file paths associated with eacch of the items. This is
useful when finding and resolving model conflicts.

The material inspector now gives the option of copying the information
to the clipboard.
@FEA-eng
Copy link
Contributor

FEA-eng commented May 20, 2024

So now only the @FreeCAD/design-working-group should have a look at this panel?

@davesrocketshop
Copy link
Contributor Author

So now only the @FreeCAD/design-working-group should have a look at this panel?

No. They definitely should (It can definitely stand improving!), but it is useful as is. It is hard to see all the information in a small dialog. Adding the copy to clipboard allows you to view it in an editor. This is a debugging tool... not a commonly used UI. Even for debugging its use will be rare.

Resizing would be wonderful but it isn't really under the dialog developers control. It is deeper in the core and I have no intentions of taking that on right now.

@FEA-eng
Copy link
Contributor

FEA-eng commented May 20, 2024

@davesrocketshop Yeah, sure, it's fine for me. @sliptonic wanted the DWG to have a look at this before merging but I also think that it should be good as it is considering the purpose of this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Materials Materials related WB Part Design Related to the Part Design Workbench WB Part Related to the Part Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants