Add a gRPC logger #214
Open
Add a gRPC logger #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelmuratoff
approved these changes
Apr 28, 2024
|
Thanks! I don't have merge power on this repo though, someone with permission needs to merge |
Frezyx
requested changes
Apr 28, 2024
There was a problem hiding this comment.
Hello @JPFrancoia !
Thank you so much for taking the time to contribute ❤️
I will merge this changes after review fix
Comment on lines
59
to
60
| class GrpcRequestLog<Q, R> extends TalkerLog { | ||
| GrpcRequestLog( |
There was a problem hiding this comment.
Can we move logs classes in different file like in talker_bloc_logger package ?
There was a problem hiding this comment.
done, moved to grpc_logs.dart
Comment on lines
177
to
178
| @override | ||
| AnsiPen get pen => (AnsiPen()..xterm(219)); |
There was a problem hiding this comment.
Please replace response log color with green like in talker_dio_logger
Comment on lines
127
to
128
| @override | ||
| AnsiPen get pen => (AnsiPen()..xterm(219)); |
There was a problem hiding this comment.
Please replace error log color with red like in talker_dio_logger
changing the color of some log messages.
|
All comments addressed! |
Frezyx
added
work_in_progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue: #201 (comment).
This PR adds a gRPC logger. This logger was inspired by the http logger and works very similarly. The logger can be used to instrument a gRPC client, allowing to transparently log gRPC calls.
The logger obfuscates authorization tokens by default (I find it really insecure to write tokens to the logs), but this can be disabled if needs be.
For now, it only supports unary RPCs, but adding streaming RPCs shouldn't be too difficult.