-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom timestamp #232
base: master
Are you sure you want to change the base?
custom timestamp #232
Conversation
if the custom time function should be the way to go let me know, |
Hello @abdelaziz-mahdy ! Sorry for the delay 🙏🏻 Example of code below: String generateTextMessage({TimeFormat timeFormat = TimeFormat.timeAndSeconds}) {
return '$<formatted time by method>$displayTitle$message$displayStackTrace';
} This implementation resolve some issues:
In this case (providing timeFormat as method arg) we can setup it in TalkerSettings in package initialization one time. |
I like that idea, since changing all of the methods was alot of work and didn't think it will be a clean approach, will check it and let you know |
my only problem is that i dont know how to pass it to settings and use it, right now my changes allow to use any time format since i added the param to the |
using your idea i think we will have a problem with this
where my previous approach didnt have a problem with it well, i fixed it ignore this. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 99.82% 98.33% -1.49%
==========================================
Files 28 17 -11
Lines 565 421 -144
==========================================
- Hits 564 414 -150
- Misses 1 7 +6 ☔ View full report in Codecov by Sentry. |
i think its now ready for a review, let me know what should be added or changed, or if its all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is great in code implementation 👍🏻
I will try to make some changes to support backward compatibility.
initial work to allow this change #231