Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #394 - Removes role="form" from form tags. #395

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

fr3nch13
Copy link
Contributor

Description

Removes role="form" from form tags.

Summarize

Write a list of the changes that were made.

  • Updated FormHelper to remove role="form"
  • Updated tests.

Benefits

Role="form" is not needed for the form tag.
Html validators will throw a notification when this is found.

Related Issues

This PR addresses the following issues.

fixes #394

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (139c7d9) 99.37% compared to head (ae23758) 99.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #395      +/-   ##
============================================
- Coverage     99.37%   99.37%   -0.01%     
  Complexity      369      369              
============================================
  Files            21       21              
  Lines          1277     1276       -1     
============================================
- Hits           1269     1268       -1     
  Misses            8        8              
Files Coverage Δ
src/View/Helper/FormHelper.php 99.28% <ø> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADmad ADmad merged commit 61ae882 into FriendsOfCake:master Oct 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option ['role' => 'form'] is not necessary for Form::create()
2 participants