Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fastly configuration rst #547

Merged
merged 11 commits into from Oct 25, 2023
Merged

Add Fastly configuration rst #547

merged 11 commits into from Oct 25, 2023

Conversation

DemigodCode
Copy link
Contributor

First version of a fastly configuration example.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! i have some tweaks

doc/fastly-configuration.rst Outdated Show resolved Hide resolved
doc/fastly-configuration.rst Outdated Show resolved Hide resolved
doc/fastly-configuration.rst Outdated Show resolved Hide resolved
DemigodCode and others added 3 commits October 25, 2023 10:15
Co-authored-by: David Buchmann <david@liip.ch>
Co-authored-by: David Buchmann <david@liip.ch>
Co-authored-by: David Buchmann <david@liip.ch>
doc/fastly-configuration.rst Outdated Show resolved Hide resolved
@dbu
Copy link
Contributor

dbu commented Oct 25, 2023

dang, there seems to be quite some code rot in the 2.x branch :-(

at leat the spellcheck build is green. i will have a look into the failing tests separately, they have nothing to do with this PR.

@dbu
Copy link
Contributor

dbu commented Oct 25, 2023

if you could rebase on 2.x branch, the readthedocs build will work again and we can check in the preview if the new documentation page looks right.

@dbu
Copy link
Contributor

dbu commented Oct 25, 2023

the preview makes me realize: we need to add fastly in the proxy-configuration.rst page to have it show up in the table of content.

https://foshttpcache--547.org.readthedocs.build/en/547/proxy-configuration.html (the stylesheet seems to be missing in the preview, thats why the page looks a bit strange - it is only applied once the changes are merged)

@DemigodCode
Copy link
Contributor Author

Yeah just realized the configuration toctree thing. Already did a push.

Co-authored-by: David Buchmann <david@liip.ch>
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks a lot for this contribution!

@dbu dbu merged commit c91dbdf into FriendsOfSymfony:2.x Oct 25, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants