refactor to phpunit 10 event system #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
refactor-to-phpunit-10-eventsystem
branch
5 times, most recently
from
bb5b6dd
to
12c3c2e
Compare
dbu
commented
Mar 26, 2024
| return; | ||
| } | ||
|
|
||
| if (null !== $this->pid || !in_array('webserver', $suite->getGroups())) { |
There was a problem hiding this comment.
we used to check the groups of the test suite, but that seems not available with phpunit 10. is there a way to know which groups a test suite includes?
dbu
force-pushed
the
refactor-to-phpunit-10-eventsystem
branch
from
12c3c2e
to
7c4f5e7
Compare
dbu
force-pushed
the
refactor-to-phpunit-10-eventsystem
branch
from
7c4f5e7
to
d06ce3f
Compare
|
if sebastianbergmann/phpunit#5769 gets solved, we can improve the setup. meanwhile i will merge, the overhead of starting |
| }, | ||
| "conflict": { | ||
| "toflar/psr6-symfony-http-cache-store": "<2.2.1", | ||
| "phpunit/phpunit": "<8" | ||
| "phpunit/phpunit": "<10" |
There was a problem hiding this comment.
It is strange that I can not use the 3.x package when my PHPUnit version is 9.6 which is still a widely. used version of PHPUnit.
I would like to avoid this conflict think most of the people will not require a test besed on the WebServerSubscriber and so this should only be a softrequirement.
There was a problem hiding this comment.
i think you are right.
fixed in 24a47d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #561