Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace styleci with php-cs-fixer #623

Closed
usu opened this issue May 2, 2024 · 3 comments · Fixed by #626
Closed

Replace styleci with php-cs-fixer #623

usu opened this issue May 2, 2024 · 3 comments · Fixed by #626

Comments

@usu
Copy link
Contributor

usu commented May 2, 2024

I'd suggest we replace styleci with php-cs-fixer to make it easier for auto-formatting during local development

Similar as done in FOSHttpCache in commit FriendsOfSymfony/FOSHttpCache@944b859
@dbu
Copy link
Contributor

dbu commented May 3, 2024

yes, i agree. i also think php-cs-fixer is more up to date with rules.

do you want to do the MR for this? after merging, i will remove the styleci hook

@usu
Copy link
Contributor Author

usu commented May 3, 2024

Yeah, I can do a PR for this. I suggest we try to merge #622 and #618 beforehand to avoid too many merge conflicts

@usu usu mentioned this issue May 3, 2024
Merged
@dbu
Copy link
Contributor

dbu commented May 4, 2024

fixed in #626

@dbu dbu closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace stylecy with php-cs-fixer usu/FOSHttpCacheBundle
2 participants
@dbu @usu