Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace stylecy with php-cs-fixer #626

Merged
merged 2 commits into from May 4, 2024

Conversation

usu
Copy link
Contributor

@usu usu commented May 3, 2024

fixes #623

.php-cs-fixer.dist.php is copied 1:1 from FOSHttpCache

@dbu
Copy link
Contributor

dbu commented May 3, 2024

thanks for this as well!

did you forget to add .php-cs-fixer.dist.php to the commit? i don't see it, and php-cs-fixer is complaining.

i will remove the hook for styleci once we merge this.

@usu
Copy link
Contributor Author

usu commented May 3, 2024

did you forget to add .php-cs-fixer.dist.php to the commit? i don't see it, and php-cs-fixer is complaining.

🤣 yeah, of course I did. fixed now.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic 🎉

@dbu dbu merged commit 3f6fe79 into FriendsOfSymfony:3.x May 4, 2024
12 of 13 checks passed
@dbu
Copy link
Contributor

dbu commented May 4, 2024

i tagged the library and the bundle

thanks a lot @usu for the help to push this over the finishing line!

btw, i think you are a fellow swiss web dev :-) we have a user group in zürich that occasionally meets: https://www.meetup.com/de-DE/sfugzh/
we also are always looking for talks, so if you want to share something that would be very welcome. but just attending is great too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace styleci with php-cs-fixer
2 participants