remove annotation for 3.X release #600
Conversation
toxicity1985
force-pushed
the
3.x
branch
2 times, most recently
from
4f2887d
to
8d454ed
Compare
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| namespace FOS\HttpCacheBundle\Http\ResponseMatcher; | |||
|
|
|||
| use Sensio\Bundle\FrameworkExtraBundle\Security\ExpressionLanguage as SecurityExpressionLanguage; | |||
| use FOS\HttpCacheBundle\Security\ExpressionLanguage as SecurityExpressionLanguage; | |||
There was a problem hiding this comment.
do we still need this class or can we remove it in favor of https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/HttpFoundation/RequestMatcher/ExpressionRequestMatcher.php
toxicity1985
force-pushed
the
3.x
branch
3 times, most recently
from
8937f49
to
5525a94
Compare
|
There is 2 bundle to be updated to be comptabile with php8.2. |
|
Do you have an idea why the rule matcher is not ok ? |
There was a problem hiding this comment.
thanks for the work!
i try to get the ball rolling with the cloudfront extension. worst case we disable the test if the component is not updated for the new version soonish.
composer.json
Outdated
| @@ -35,21 +35,20 @@ | |||
| "guzzlehttp/guzzle": "^7.2", | |||
| "mockery/mockery": "^1.3.2", | |||
| "monolog/monolog": "*", | |||
| "sensio/framework-extra-bundle": "^4.0 || ^5.5.1 || ^6.0", | |||
| "doctrine/annotations": "^1.11", | |||
| { | ||
| /** | ||
| * @var string Regular expression to match the query string part of the request url | ||
| */ | ||
| private $queryString; | ||
|
|
||
| public function __construct($queryString = null) |
There was a problem hiding this comment.
when we add this to the constructor, i'd like to remove the setter for queryString.
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| */ | ||
| interface ConfigurationInterface |
There was a problem hiding this comment.
looking at how we use this in Php8AttributesListener i would prefer to do a match on $instance to see if it is one of the 3 known attribute classes and if so add it with the corresponding alias name. this interface is not really adding value anymore i think.
toxicity1985
force-pushed
the
3.x
branch
3 times, most recently
from
6ca324d
to
1a28a99
Compare
|
Hi, I update the plugin this morning. I add a match function as asked but the get alias is necessary to add configuration inside the request. I juste have a question regards the invalidation path attribute. If we have a match we have to clear the path configured inside the attribute but not the route called ? |
No description provided.