Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling container using Secrets #605

Closed
wants to merge 13 commits into from

Conversation

DemigodCode
Copy link
Contributor

If one wants to use secrets as parameters for fastly or cloudflare, the compiling of the container will fail.
After compiling the container the termination event will cause this error cause it's not necessary to have the decrypt key available when compiling the container and the service can't be initialized.

This fix creates the services as lazy services which will not make the options necessary on compile time of the container.

@DemigodCode
Copy link
Contributor Author

DemigodCode commented Dec 18, 2023

Don't know why readthedocs is failing, did not change anything there.

Also don't know why the unit tests are failing cause of simple-phpunit. That's maybe something else?

@dbu
Copy link
Contributor

dbu commented Dec 19, 2023

thanks for this pull request. indeed, makes sense to make the services lazy to avoid the problem you describe.

we are close to release version 3 of the bundle for new symfony versions. the build seems to have rotten again on the 2.x branch. could you base this PR onto the 3.x branch? then it will be in the upcoming release and the CI should work out.

@DemigodCode DemigodCode changed the base branch from 2.x to 3.x December 19, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants