Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidourianis: fix token controller type hinting #687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HidouriAnis
Copy link

We should use Interface type hinting. i have a problem with this type hinting when I needed to create a decorator for a custom createAccessToken method

@HidouriAnis HidouriAnis marked this pull request as draft December 14, 2021 12:46
Copy link
Collaborator

@deguif deguif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog?

@HidouriAnis HidouriAnis marked this pull request as ready for review February 22, 2022 13:36
@HidouriAnis HidouriAnis deleted the fix-tokencontroller-type-hint branch October 18, 2022 18:29
@HidouriAnis HidouriAnis restored the fix-tokencontroller-type-hint branch October 18, 2022 18:31
@HidouriAnis HidouriAnis reopened this Oct 18, 2022
@HidouriAnis HidouriAnis marked this pull request as draft October 18, 2022 18:34
@HidouriAnis HidouriAnis marked this pull request as ready for review October 18, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants