Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RESETTING_SEND_EMAIL_FAILURE. #2829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

phpeek
Copy link

@phpeek phpeek commented Aug 5, 2018

Currently when resetting password, whenever username is not found or password request is expired, RedirectResponse to fos_user_resetting_check_email is being returned with GET parameter username.

I used to get a warnings from Google about username parameter with email being present on my websites.

There's no simple way to change this without this event.

Connected with:
#2752
#2652 (kinda)

@phpeek
Copy link
Author

phpeek commented Aug 5, 2018

Travis is failing due to memory exhaustion. 😢

@phpeek phpeek force-pushed the add-not-send-resetting-email-event branch 2 times, most recently from dc40369 to fc2899f Compare August 5, 2018 18:57
@phpeek phpeek force-pushed the add-not-send-resetting-email-event branch from 6e8058e to 02f6a51 Compare August 6, 2018 19:52
@phpeek
Copy link
Author

phpeek commented Aug 6, 2018

@XWB I see You've increased memory limit on Travis in master. I've also changed ordering of before_install commands in Travis config so that memory limit is increased before composer kicks in.

Credits goes to @kubawerlos who spotted it.

@XWB
Copy link
Member

XWB commented Aug 7, 2018

@phpeek Thanks for the tip, I've just fixed it in master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants