Bako ID integration #1180
Draft
Bako ID integration #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luisburigo
commented
Apr 3, 2024
Comment on lines
+62
to
+68
| if (!name && isReceiver) { | ||
| resolveAddressName(); | ||
| } | ||
|
|
||
| if (!isReceiver) { | ||
| setAccountName(); | ||
| } |
There was a problem hiding this comment.
I added it only to show in the receiver, thinking about the transaction sending flow, what do you think?
If they're not a receiver, there could be a conflict with the wallet name.
luisburigo
commented
Apr 3, 2024
Comment on lines
+71
to
+77
| const Name = !name ? ( | ||
| <ContentLoader width={100} height={17} viewBox="0 0 80 17"> | ||
| <ContentLoader.Rect x="0" y="0" width="100" height="17" rx="4" /> | ||
| </ContentLoader> | ||
| ) : ( | ||
| `${name}` | ||
| ); |
There was a problem hiding this comment.
I added a loader to the name to avoid screen flickering when the search is completed.
luisburigo
requested review from
luizstacio,
pedronauck,
LuizAsFight and
helciofranco
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables sending a transaction by handles in Bako, handle is
@with a identifier name, an example:@fuel_network馃憞{ "owner": "0x000...", "resolver": "0x000...", }Check Bako ID docs
Changes:
Bech32or@bako_handleresolveraddress@bako-id/sdk@0.0.6package