fix: for starting accounts at Account 1 and added new test #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.51% | 3228/5164 |
| 🔴 | Branches | 42.05% | 627/1491 |
| 🔴 | Functions | 46.94% | 682/1453 |
| 🟡 | Lines | 63.07% | 3110/4931 |
Test suite run success
240 tests passing in 70 suites.
Report generated by 🧪jest coverage report action from ffc44ac
HoTandy
requested review from
luizstacio,
pedronauck,
LuizAsFight and
helciofranco
as code owners
There was a problem hiding this comment.
Just two comments:
- Missing to add a changeset for these changes.
It can be an "empty" changeset since these changes are not in the app itself.
pnpm changeset --emptyand then commit and push that file.
- Also, the PR title should be updated to use the prefix "
fix:" (there's a CI routine failing due to the PR title).
HoTandy
changed the title
helciofranco
approved these changes
May 27, 2024
LuizAsFight
requested changes
May 27, 2024
LuizAsFight
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the mock object, the Accounts were labelled starting at
Account 0, this doesn't match reality so now they start atAccount 1In popup.ts, I've added functions for doing the following through the UI
-- creating an account -
createAccount-- creating an account from private key -
createAccountFromPrivateKey-- extracting text from the clipboard -
getClipboardText-- getting the fuel address for an account number -
getAddressForAccountNumber-- exporting the private key -
exportPrivateKey(not yet used and not sure if it's working properly)In
Accounts.test.tsI've created a test that checks to make sure the same addresses are getting added when we add new accounts, even after importing an account using that account's private key.