Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework book intro #5972

Merged
merged 4 commits into from May 9, 2024
Merged

Rework book intro #5972

merged 4 commits into from May 9, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 7, 2024

Description

Rewrote much of the book introduction to better explain the vision for Sway, how it compares to both Solidity and Rust, address some of the misconceptions in it and generally make it more appealing to people who are just discovering Sway.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added the The Sway Book Everything to do with the Sway Book label May 7, 2024
@IGI-111 IGI-111 requested review from tritao, sarahschwartz and a team May 7, 2024 23:46
@IGI-111 IGI-111 force-pushed the IGI-111/docs-intro branch 4 times, most recently from 2ad7454 to d14dccd Compare May 7, 2024 23:59
@IGI-111
Rework book intro
6101625 
Rewrote much of the book introduction to better explain the vision for
Sway, how it compares to both Solidity and Rust, address some of the
misconceptions in it and generally make it more appealing to people who
are just discovering Sway.
xunilrj
xunilrj previously approved these changes May 8, 2024
View reviewed changes
tritao
tritao previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@tritao tritao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions, but otherwise lgtm.

docs/book/src/index.md Outdated Show resolved Hide resolved
docs/book/src/index.md Outdated Show resolved Hide resolved
docs/book/src/index.md Outdated Show resolved Hide resolved
@IGI-111 IGI-111 dismissed stale reviews from tritao and xunilrj via 9f1b217 May 8, 2024 16:07
@IGI-111 IGI-111 requested review from xunilrj and tritao May 8, 2024 16:07
sarahschwartz
sarahschwartz previously approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@sarahschwartz sarahschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@IGI-111 IGI-111 requested a review from sarahschwartz May 9, 2024 02:51
@IGI-111 IGI-111 requested a review from a team May 9, 2024 18:27
@IGI-111 IGI-111 merged commit 58944ae into master May 9, 2024
41 checks passed
@IGI-111 IGI-111 deleted the IGI-111/docs-intro branch May 9, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@sarahschwartz sarahschwartz sarahschwartz approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
The Sway Book Everything to do with the Sway Book
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IGI-111 @xunilrj @tritao @sarahschwartz @JoshuaBatty