fix the toc for securing webhooks #2759
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooreds
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Would be awesome to correct this name to _securing-http-requests.mdx to conform to our standards.
| @@ -1,11 +1,11 @@ | |||
| --- | |||
| --- | |||
| ### TLS v1.2 | |||
| ## TLS v1.2 | |||
There was a problem hiding this comment.
This breaks the outline of the two other places this is used
grep -Rl _securing_http_requests
./extend/events-and-webhooks/securing.mdx
./lifecycle/migrate-users/connectors/generic-connector.mdx
./customize/email-and-messages/generic-messenger.mdx
Suggest we keep it at an h3 and add another header in there. I can take a swing at this if you'd like. (We need to add in the webhook signing section anyway.)
|
|
||
| ## Securing Webhooks | ||
| export const headings = securing.getHeadings(); |
There was a problem hiding this comment.
Do we need to do this for the other two places we include this file?
|
@lyleschemmerling any plans to make changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in order to get that toc to populate needed to add the nested headings frontmatter param and export the headings from the sub component. Our implementation of the TOC expected some h2s and not only h3s so I changed those to make them populate and think that it looks okay, but am interested in what you think.
Related: