Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(breadcrumb): replace 'strong' with 'breadcrumb' tags #3043

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

escii
Copy link
Collaborator

@escii escii commented Apr 28, 2024

@escii escii requested a review from tonyblank April 28, 2024 23:30
…tro-breadcrumb

# Conflicts:
#	astro/src/content/docs/_shared/_admin-user-form.mdx
#	astro/src/content/docs/_shared/_admin-user-registration-form.mdx
Copy link

@tonyblank tonyblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - so many breadcrumbs, I feel like a duck!

@Aaron-Ritter
Copy link
Collaborator

Aaron-Ritter commented May 18, 2024

thanks for the review @tonyblank while merging the latest updates i found a mistake in a few changes we did where it should have been replaced with <UIelement></UIelement> instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants