Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quake mode terminal module #256

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

andydotxyz
Copy link
Contributor

@andydotxyz andydotxyz commented Feb 11, 2024

Last feature addition for v0.4 I think :)

quake-term-final.mp4

Checklist:

  • Tests included. <- I couldn't figure out how to test the show, which is the only real code addition as the widget is from terminal package
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Feb 11, 2024

Pull Request Test Coverage Report for Build 7970876290

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -7 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • 32 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 28.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/ui/desk.go 0 3 0.0%
internal/x11/wm/desk.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
internal/ui/widgetpanel.go 11 86.71%
internal/ui/switcher.go 21 83.66%
Totals Coverage Status
Change from base Build 7773297480: 0.4%
Covered Lines: 1602
Relevant Lines: 5530

💛 - Coveralls

}
t.hide() // terminal exited

t.createTerm() // reset for next usage
Copy link
Member

@taigrr taigrr Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tmux auto-launch from my .bashrc (with a check to make sure it isn't already running.) The way this is written here will cause my tmux sessions to pile up rather quickly, if I'm understanding it correctly.

Looks like this behavior might not play nicely with pinentry-ncurses for Yubikey users. Is there a way to only spawn the shell JIT, right before the user actually sees it, rather than optimistically spawning it and leaving it open in the background 24/7 if the module is enabled?

Copy link
Member

@taigrr taigrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly concerned about implications for sessionized tmux / pinentry but love the idea

@andydotxyz
Copy link
Contributor Author

I made it lazy load the terminal, that should fix the concern I think?

@taigrr
Copy link
Member

taigrr commented Feb 21, 2024

Looks good now!

@andydotxyz andydotxyz merged commit 632a47c into FyshOS:develop Feb 21, 2024
5 checks passed
@andydotxyz andydotxyz deleted the feature/quaketerm branch February 21, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants