feat: support eslint v8 #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
support-eslint-v8
branch
from
f856467
to
8d884e5
Compare
G-Rath
force-pushed
the
support-eslint-v8
branch
from
b6ca2be
to
dbd4fe9
Compare
G-Rath
force-pushed
the
support-eslint-v8
branch
from
0297c7b
to
5c3b3f9
Compare
SimenB
reviewed
Jan 31, 2022
| @@ -79,7 +79,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@typescript-eslint/experimental-utils": "^4.11.1", | |||
| "@typescript-eslint/experimental-utils": "^5.0.0", | |||
There was a problem hiding this comment.
Suggested change
| "@typescript-eslint/experimental-utils": "^5.0.0", | |
| "@typescript-eslint/utils": "^5.10.0", |
?
😀
There was a problem hiding this comment.
@G-Rath any news on this one? This change is what's keeping this around: https://github.com/jest-community/eslint-plugin-jest/blob/78a714187d1ab0fffd2b8dc5f1ea5e41692856e6/package.json#L158-L160
There was a problem hiding this comment.
ah right, in that case let's axe this from eslint-plugin-jest - it's not possible to support ESLint v8 because it removes the synchronous API this plugin requires and I can't use the async version since rules can't be async (yet) 🤷
(I thought I put that somewhere, but can't find the comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.