Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint check #249

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable Lint check #249

wants to merge 5 commits into from

Conversation

ljubon
Copy link
Contributor

@ljubon ljubon commented Jan 31, 2024

Checklist before submitting

  • Did you read the contributing guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?

Description

The goal of this change is to enable linting as required check for the CI
example run: https://github.com/ljubon/spark-dgraph-connector/actions/runs/6946230885/job/18897234201

Fixes # (issue).

Review process for approval

  1. All tests and other checks must succeed.
  2. At least one core contributors must review and approve.
  3. If a core contributor requests changes, they must be addressed.

@EnricoMi
Copy link
Collaborator

I'd prefer to do this the same way we did in G-Research/spark-extension#201 and G-Research/spark-extension#212.

Copy link

Test Results

0 files   -  2 996  0 suites   - 2 996   0s ⏱️ - 51m 43s
0 tests  -    485  0 ✅  -    485  0 💤 ±0  0 ❌ ±0 
0 runs   - 42 988  0 ✅  - 42 988  0 💤 ±0  0 ❌ ±0 

Results for commit 76ee286. ± Comparison against base commit d7efaad.

@ljubon
Copy link
Contributor Author

ljubon commented May 20, 2024

I'd prefer to do this the same way we did in G-Research/spark-extension#201 and G-Research/spark-extension#212.

In latest commit, i've applied changes from suggested PRs/commits:

p.s format is not applied, so it's expected that action Linting is failing - let me know if you want me to commit to this PR formated code which will affect the files in src/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants