-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Release workflow #237
base: master
Are you sure you want to change the base?
CI: Release workflow #237
Conversation
|
||
- name: Import GPG key | ||
id: sign | ||
uses: crazy-max/ghaction-import-gpg@01dd5d3ca463c7f10f7f4f7b4f177225ac661ee4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to set the GPG_PRIVATE_KEY
secret. Which key do you propose we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EnricoMi , in latest commit i added a environment release
for this step - could you please create this environment and secret associated to it?
It would be best to have enabled Deployment branches and tags
with Selected branches and tags
as this job would be triggered only from v*
tags pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use a private key owned by GR here, not my personal one? Same with the OSSRH login, that should be a general GR login used by all packages that deploy to maven, not a personal access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can provide the key and credentials as environment secrets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need PyPi credentials.
FYI rebase & resolving config is done |
i just realised during resolving conflict i lost few changes that should be here, will move this PR as draft until i get them back |
d46337d
to
3cde51b
Compare
id: sign | ||
uses: crazy-max/ghaction-import-gpg@01dd5d3ca463c7f10f7f4f7b4f177225ac661ee4 | ||
with: | ||
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljubon which environment do we use for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release
is the name of environment which we should use, I'm just gonna push that change, as currently release
environment is only added to publish-release.yml
at the moment
Previous PR for the same topic was #200, but closed as it required major changes and approach which is shown in this PR
What type of PR is this?
This is an improvement PR with the goal of enabling spark-extension release using GitHub workflows
What this PR does / why we need it:
The goal of this task is to move the release process to GitHub workflow from current scripts that are run manually.
The current release process is documented in [RELEASE.md](https://github.com/G-Research/spark-extension/blob/master/RELEASE.md/.
Due to its complexity, we reached out to one of the maintainers Enrico who approved this idea of moving
release.sh
to a github workflow for it's transparent and better usage.Resolves: https://github.com/G-Research/oss-portfolio-maturity/issues/32
Acceptance criteria / Notes for the reviewer:
Most of the comments and testing were done forked repo
Part of maturity matrix: https://github.com/G-Research/oss-portfolio-maturity/issues/32