Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Bump Azure Ubuntu to 22.04 #10212

Closed
wants to merge 2 commits into from
Closed

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Apr 29, 2024

🤖 Nope

👋 Introduction

Bumps the Azure pipelines version of Ubuntu to v22 to be kept in line with all other environments and instances.

🧪 Testing

  1. Test deployment and build I assume

🚚 Deployment

?

FAIL 💀

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (7ee9d49) to head (bcd27d5).

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10212       +/-   ##
=============================================
+ Coverage     35.59%   69.01%   +33.41%     
  Complexity     1321     1321               
=============================================
  Files          1061      209      -852     
  Lines         30579     5151    -25428     
  Branches       6403        0     -6403     
=============================================
- Hits          10885     3555     -7330     
+ Misses        19671     1596    -18075     
+ Partials         23        0       -23     
Flag Coverage Δ
integrationtests 69.01% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vd1992 vd1992 requested a review from brindasasi April 29, 2024 22:30
@vd1992
Copy link
Contributor Author

vd1992 commented Apr 29, 2024

I think I'll need your help to test the deploy/build please @brindasasi 😄

@petertgiles petertgiles self-requested a review April 30, 2024 12:33
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh, looks like you might have some more to do on this one. I have no idea what this means - some googling I guess. 😁
image

@petertgiles
Copy link
Contributor

petertgiles commented Apr 30, 2024

Maybe PHP 8.2 isn't available in this image? The later image has less options for PHP? Very strange... What are we going to do when this image becomes deprecated?
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md#php-tools
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#php-tools

@petertgiles
Copy link
Contributor

OK, I found out more about it.
actions/runner-images#6331
It looks like they removed any non-official PHP sources in the image. Since Ubuntu 22.04 came with PHP 8.1 that's the only one available.

In the linked page they recommend using setup-php to get other versions of PHP. Like we already do in our GH workflows, I guess.

@mnigh mnigh changed the title [Debt] Bump Azure Ubunto to 22 [Debt] Bump Azure Ubuntu to 22.04 Apr 30, 2024
@vd1992
Copy link
Contributor Author

vd1992 commented Apr 30, 2024

No luck 🤕

@mnigh
Copy link
Contributor

mnigh commented May 16, 2024

What are we going to do when this image becomes deprecated?

@petertgiles Great question, not sure there is much we can do if the new trend continues for runners where they only include support for one version of PHP. The newest Ubuntu runner, Ubuntu 24.04, only supports 8.3 which would mean we would be forced to upgrade the runner and the PHP version we use at the exact same time. Also, it would mean that we would be stuck with both until a new runner version is released.

Using setup-php works in our GitHub workflows because it is a GitHub action, but there isn't an equivalent task (as they are known in Azure Pipelines) for Azure Pipelines, or at least that I could find. My guess that the documentation that shows how to set a different PHP version was relevant for runners that had multiple versions of PHP installed (for example, ubuntu-20.04) but not for anything >=22.04.

😨 Also, strange that there cases where the runner is actually using the ondrej/php ppa:

https://github.com/actions/runner-images/blob/4abf97ab13928c4731cb243a72225c55436832fc/images/ubuntu/scripts/build/install-php.sh#L15C24-L15C38

@petertgiles
Copy link
Contributor

Using setup-php works in our GitHub workflows because it is a GitHub action

Yeah, I was looking at the setup-php action to see how it works and I think it's just using the ondrej PPA for Ubuntu. It makes me a little nervous to use a third party PPA to build our software but of course we're using this in an action already and it's not an obscure source. I think we'll just end up having to add this to our pipeline.

@vd1992 vd1992 deleted the 10202-azure-ubuntu-version-bump branch May 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants