Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spike for Cypress E2E testing #2568

Merged
merged 17 commits into from
Apr 27, 2022
Merged

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Apr 26, 2022

Resolves #1762

@patcon patcon self-assigned this Apr 26, 2022
@patcon patcon marked this pull request as draft April 26, 2022 23:06
@patcon
Copy link
Contributor Author

patcon commented Apr 27, 2022

Yay! It works!

It takes quite some time to run setup.sh, but the docker build went from 1min to 3s with the layer caching, so that's a good sign that this will be real quick once we have the app actually building in docker :)

Screen Shot 2022-04-26 at 8 09 00 PM

cc: @petertgiles

@patcon
Copy link
Contributor Author

patcon commented Apr 27, 2022

Going to back out of the reporting goal, as it's a little fraught.

Examples:

both reporters took awhile to debug because the check results are showing up under "Bundlewatch" check for some reason, which is perhaps due to "Bundlewatch" action doing something non-standard.

Also, there's some confusing work to make GitHub check reports work for forks:
https://github.com/EnricoMi/publish-unit-test-result-action/tree/v1.20#support-fork-repositories-and-dependabot-branches

Also, cypress has an issue with mocha reporters can't have their output locations configured right now:
cypress-io/cypress#18014

tl;dr - too many rabbit holes here!

@patcon patcon marked this pull request as ready for review April 27, 2022 14:38
@patcon
Copy link
Contributor Author

patcon commented Apr 27, 2022

@petertgiles the interface won't see to let me, but I'm undesignating you as reviewer! [EDIT: figured it out 🙃 ] (I am too quick to tag you, and it's a bad habit 🙂 )

@esizer @yonikid15 you seem like you'd get a kick out of e2e tests. Care to review when you get a sec? :)

@patcon patcon removed the request for review from petertgiles April 27, 2022 14:40
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just noticed a small change to the footer test descriptions

@patcon
Copy link
Contributor Author

patcon commented Apr 27, 2022

Added an line comment: Some of the footer checks are skipped until this bug is fixed
#2565

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 🍭

@patcon patcon merged commit 22d6b2b into GCTC-NTGC:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Cypress for end-to-end testing
2 participants