Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt/3228-react-strict #5345

Merged
merged 1 commit into from Jan 16, 2023
Merged

debt/3228-react-strict #5345

merged 1 commit into from Jan 16, 2023

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Jan 13, 2023

πŸ€– Resolves #3228

πŸ‘‹ Introduction

Activate strict mode

πŸ•΅οΈ Details

So far seems to work fine for the most part. One exception with a warning thrown everywhere as seen below

This appears to originate from react-helmet and is an issue noted here nfl/react-helmet#694
The suggested solution does not work and is the same problem as seen here staylor/react-helmet-async#145
Given this is a Warning and not Error thrown, it isn't a huge issue at the moment.

πŸ§ͺ Testing

  1. Ensure nothing broke
  2. ?

πŸ“Έ Screenshot

image

@esizer
Copy link
Member

esizer commented Jan 16, 2023

This appears to originate from react-helmet and is an issue noted here nfl/react-helmet#694
The suggested solution does not work and is the same problem as seen here staylor/react-helmet-async#145
Given this is a Warning and not Error thrown, it isn't a huge issue at the moment.

Agreed. Also, while looking into this I noticed react-helmet doesn't seem to be maintained anymore. I think it would be a good idea to migrate to react-helmet-async regardless if this issue has been resolved. I'll throw an issue πŸ‘


Update
Issue has been created #5346

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ⭐

I put up an issue to migrate to react-helmet-async on the board. I think you are correct on the issue not being super urgent but def something we should look at.

@vd1992 vd1992 merged commit 5012a00 into main Jan 16, 2023
@vd1992 vd1992 deleted the debt/3228-react-strict branch January 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use React StrictMode
2 participants