Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy - 5426 - Updates experience type community in French #5427

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Jan 20, 2023

🤖 Resolves #5426.

👋 Introduction

This PR updates French copy for Community so that it is more consistent with related French copy for similar words related to Experiences types. Related to #5419.

🧪 Testing

  1. Compile French npm run intl-compile
  2. Build talentsearch npm run dev
  3. Navigate to /fr/users/:id/profile/experiences
  4. Verify button is Communautaire
  5. Verify experience buttons layout has buttons with the same height (thanks @substrae!)
  6. Navigate to /fr/users/:id/profile/experiences
  7. Click on Par type to list by type
  8. Verify heading is Expériences communautaires

@esizer
Copy link
Member

esizer commented Jan 20, 2023

We may want to see what we can do about that button 😅

Screenshot 2023-01-20 170536

@vd1992
Copy link
Contributor

vd1992 commented Jan 21, 2023

🇫🇷 😢

@mnigh
Copy link
Contributor Author

mnigh commented Jan 23, 2023

We may want to see what we can do about that button 😅

Screenshot 2023-01-20 170536

@GCTC-NTGC/designers any ideas?

@Jerryescandon
Copy link

Related to #4389 , maybe the fix is just updating the whole shabang to a nice plump modal.

accounts for longer strings in both EN and FR
@mnigh mnigh requested a review from esizer January 23, 2023 16:59
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🍭

@mnigh
Copy link
Contributor Author

mnigh commented Jan 23, 2023

@GCTC-NTGC/developers could someone look at the Chromatic UI Review for this PR and approve it? @esizer tried but cannot see it (possibly related to #5181?). I also have an open thread going with the Chromatic chatbot to see if it is something they can fix.

@vd1992
Copy link
Contributor

vd1992 commented Jan 23, 2023

what is going on here

image

@mnigh
Copy link
Contributor Author

mnigh commented Jan 23, 2023

what is going on here

image

Not sure, there are a number of changes in that diff set that are in no way related to this PR and must have been left over from other changes made that were merged into main without having run Chromatic on them.

@esizer
Copy link
Member

esizer commented Jan 23, 2023

what is going on here

Looks like the MyApplications page required a userId as a prop and we are not passing it in the story. I can create an issue for it.


Update: Created issue #5431

@mnigh
Copy link
Contributor Author

mnigh commented Jan 23, 2023

PHP Unit Tests GitHub workflow failing is related to an existing issue in the setup-php project. This PR has nothing PHP-related, in any case.

Thanks again to @substrae for the macgyver layout for the experience buttons, @esizer for surfacing the issue, and @vd1992 for surfacing the MyApplications storybook issue via a diff set screenshot 🏅!

@mnigh mnigh merged commit bb537c0 into main Jan 23, 2023
@mnigh mnigh deleted the copy/5426-community-fr branch January 23, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy - French - Collectivité to Communautaire
4 participants