Set a reasonable min version for serde_json #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serde_json 1.0.25 brings in the json! macro that is used here (https://github.com/serde-rs/json/releases/tag/v1.0.25)
|
Thanks, this change is in schemars 0.8.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is use be able to compile a project using schemars with
cargo +nightly build -Zminimal-versionsto ensure the min versions are all set correctly.Here serde_json was set to ^1.0.0 but this is not the actual min version we need. serde_json 1.0.25 brings in the
json!macro that is used here (https://github.com/serde-rs/json/releases/tag/v1.0.25).