Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bigdecimal 0.4 #237

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Support bigdecimal 0.4 #237

merged 1 commit into from
Sep 17, 2023

Conversation

adamchalmers
Copy link
Contributor

@adamchalmers adamchalmers commented Aug 25, 2023 •
edited

I copied the approach from other similar packages (e.g. uuid 0.8 vs 1.0) to ensure backwards compatibility.

@adamchalmers adamchalmers force-pushed the achalmers/bigdecimal-04-support branch 3 times, most recently from 59914b0 to 76b437c Compare August 25, 2023 20:49
@adamchalmers adamchalmers force-pushed the achalmers/bigdecimal-04-support branch from 76b437c to e1f6e63 Compare August 28, 2023 22:00
@adamchalmers
Copy link
Contributor Author

@GREsau Hi! Sorry for the broken PR. I hadn't figured out how to do dep: features properly. But since you bumped the minimum Rust version to 1.60, this is now working :)

@adamchalmers
Copy link
Contributor Author

@GREsau Hi! Sorry to ping you again, but, could I please ask for a review on this?

@GREsau GREsau merged commit cc28738 into GREsau:master Sep 17, 2023
4 checks passed
@GREsau
Copy link
Owner

GREsau commented Sep 17, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamchalmers @GREsau