Merge pull request #486 from kahless/master

Recognize destructured assignment to a new name (fixes #485)
Galooshi · Mar 16, 2018 · 0ba5fec · 0ba5fec
2 parents 6d90ded + 7e1e4c0
commit 0ba5fec
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/lib/__tests__/findUndefinedIdentifiers-test.js b/lib/__tests__/findUndefinedIdentifiers-test.js
@@ -25,6 +25,14 @@ it('recognizes destructured assignment', () => {
   `))).toEqual(new Set([]));
 });
 
+it('recognizes destructured assignment to a new name', () => {
+  expect(findUndefinedIdentifiers(parse(`
+    import Foo from 'foo';
+    const { bar: scar } = Foo;
+    scar();
+  `))).toEqual(new Set([]));
+});
+
 it('knows about scope', () => {
   expect(findUndefinedIdentifiers(parse(`
     () => {

diff --git a/lib/visitIdentifierNodes.js b/lib/visitIdentifierNodes.js
@@ -56,7 +56,10 @@ function normalizeNode(node, context) {
   const isAssignment = KEYS_USED_FOR_ASSIGNMENT.has(key) ||
     (key === 'key' && parent.parent.type === 'ObjectPattern') ||
     (key === 'left' && parent.type === 'AssignmentPattern') ||
-    (key === 'elements' && parent.type === 'ArrayPattern');
+    (key === 'elements' && parent.type === 'ArrayPattern') ||
+    (key === 'value' &&
+      parent.parent.type === 'ObjectPattern' &&
+      parent.parent.parent.type === 'VariableDeclarator');
   if (isAssignment) {
     context.definedInScope.add(node.name);
   }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "import-js",
-  "version": "2.10.0",
+  "version": "2.10.1",
   "description": "Simplifies importing JavaScript modules",
   "bin": {
     "importjs": "./bin/importjs.js",