Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): Add extraparams parameter to all gameservers #2120

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

borzaka
Copy link
Contributor

@borzaka borzaka commented Dec 15, 2018

Description

Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg

Fixes #2183

Type of change

  • Bug fix (non breaking change which fixes an issue)
  • New feature (non breaking change which adds functionality)
  • Refactor (non breaking change restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • I have performed a self review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation

Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg
@Frisasky
Copy link
Contributor

i have synced the PR with latest develop codebase, it should be ready for testing

@Frisasky Frisasky requested a review from dgibbs64 July 11, 2019 00:45
@dgibbs64
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 1
           

See the complete overview on Codacy

@pull-assistant
Copy link

pull-assistant bot commented Mar 17, 2020

Score: 0.89

Best reviewed: commit by commit


Optimal code review plan (8 warnings)

Add extraparams parameter to all gameservers

...lgsm/codwawserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/bsserver/_default.cfg 50% changes removed in Merge branch 'develo...

...-lgsm/coduoserver/_default.cfg 50% changes removed in Merge branch 'develo...

...g-lgsm/cod2server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/insserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/q3server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/codserver/_default.cfg 50% changes removed in Merge branch 'develo...

...g-lgsm/rustserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/tuserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/twserver/_default.cfg 50% changes removed in Merge branch 'develo...

...g-lgsm/cod4server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/doiserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/dstserver/_default.cfg 75% changes removed in Merge branch 'develo...

...-lgsm/pstbsserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/ut3server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/etlserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/boserver/_default.cfg 50% changes removed in Update _default.cfg

...g-lgsm/inssserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/kf2server/_default.cfg 50% changes removed in Merge branch 'develo...

...lgsm/bt1944server/_default.cfg 50% changes removed in Merge branch 'develo...

...-lgsm/nmrihserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/pzserver/_default.cfg 67% changes removed in Merge branch 'develo...

Merge branch 'develop' into add-extraparams-parameter

...ctions/install_server_files.sh 40% changes removed in Merge branch 'develo...

...gsm/functions/query_gsquery.py 75% changes removed in Merge branch 'develo...

tests/tests_jc2server.sh 41% changes removed in Merge branch 'develo...

...functions/install_ut2k4_key.sh 50% changes removed in Merge branch 'develo...

tests/tests_ts3server.sh 41% changes removed in Merge branch 'develo...

...functions/check_tmuxception.sh 75% changes removed in Merge branch 'develo...

...gsm/functions/query_gamedig.sh 48% changes removed in Merge branch 'develo...

tests/tests_fctrserver.sh 42% changes removed in Merge branch 'develo...

...tions/command_dev_query_raw.sh 58% changes removed in Merge branch 'develo...

...UE_TEMPLATE/feature_request.md 41% changes removed in Merge branch 'develo...

CONTRIBUTING.md 67% changes removed in Merge branch 'develo...

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

Update _default.cfg

...ig-lgsm/untserver/_default.cfg 50% changes removed in Merge branch 'develo...

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

Merge branch 'develop' into add-extraparams-parameter

...gsm/functions/info_messages.sh 44% changes removed in Merge branch 'develo...

...gsm/functions/command_debug.sh 50% changes removed in Merge branch 'develo...

Merge branch 'develop' into add-extraparams-parameter

...gsm/functions/command_start.sh 67% changes removed in Merge branch 'develo...

...sm/functions/command_fastdl.sh 67% changes removed in Merge branch 'develo...

linuxgsm.sh 50% changes removed in Merge branch 'develo...

     add extraparams

     add extraparams

     add extraparams

Merge branch 'develop' into add-extraparams-parameter

lgsm/functions/info_distro.sh 41% changes removed in Merge branch 'develo...

...-lgsm/pstbsserver/_default.cfg 67% changes removed in Merge branch 'develo...

lgsm/functions/check_deps.sh 62% changes removed in Merge branch 'develo...

...ig-lgsm/etlserver/_default.cfg 80% changes removed in Merge branch 'develo...

...gsm/functions/query_gamedig.sh 43% changes removed in Merge branch 'develo...

     add extraparams

     add extraparams

Merge branch 'develop' into add-extraparams-parameter

...ons/command_ts3_server_pass.sh 50% changes removed in Merge branch 'develo...

lgsm/functions/mods_core.sh 57% changes removed in Merge branch 'develo...

Merge branch 'develop' into add-extraparams-parameter

lgsm/functions/check_deps.sh 55% changes removed in Merge branch 'develo...

     Update _default.cfg

     Merge branch 'develop' into add-extraparams-parameter

Powered by Pull Assistant. Last update 9c2ce41 ... 42c9f14. Read the comment docs.

@Frisasky Frisasky changed the title Add extraparams parameter to all gameservers feat(refactor): Add extraparams parameter to all gameservers Mar 17, 2020
@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:develop January 27, 2021 20:51
@dgibbs64 dgibbs64 reopened this Jan 27, 2021
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Jan 28, 2021
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from f02e53d to 2257be4 Compare October 22, 2022 21:53
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from 891ed8f to ca184e3 Compare September 7, 2023 20:23
@dgibbs64 dgibbs64 force-pushed the develop branch 2 times, most recently from 7a72c04 to f28a4e5 Compare December 3, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch conflicts Branch of pr has conflicts that need to be worked on type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants