Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MessageCommandHandler): arguments support #337

Merged
merged 36 commits into from
Feb 13, 2022

Conversation

xHyroM
Copy link
Member

@xHyroM xHyroM commented Feb 9, 2022

Please describe the changes this PR makes and why it should be merged:
I know that message commands are no longer supported even by discord, but we are a framework that is mainly used for merging, so we should support this.

Other reasons:

  1. The slash command is just not suitable for some things.
  2. Slash commands are evolving fast, making progress but still things are not perfect

This support will be so basic, we still prefer slash commands.
^ We can't support autocomplete but only choices in message command handler.

Status and versioning classification:

  • This PR changes the library's interface (methods or parameters added)

Wait for

@xHyroM xHyroM marked this pull request as draft February 9, 2022 19:20
@xHyroM xHyroM marked this pull request as ready for review February 13, 2022 10:59
@xHyroM xHyroM requested a review from S222em February 13, 2022 10:59
@iZboxo iZboxo merged commit 0a0aef2 into Garlic-Team:next Feb 13, 2022
@bucket-bot
Copy link

bucket-bot bot commented Feb 13, 2022

I'm locking the conversation so as not to create unnecessary controversy. Use /unlock to unlock

@bucket-bot bucket-bot bot locked and limited conversation to collaborators Feb 13, 2022
Copy link
Member

@iZboxo iZboxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants