-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MessageCommandHandler): arguments support #337
Merged
iZboxo
merged 36 commits into
Garlic-Team:next
from
xhyrom-forks:feat/message-arguments
Feb 13, 2022
Merged
feat(MessageCommandHandler): arguments support #337
iZboxo
merged 36 commits into
Garlic-Team:next
from
xhyrom-forks:feat/message-arguments
Feb 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommands into feat/message-arguments
xHyroM
force-pushed
the
feat/message-arguments
branch
from
February 9, 2022 19:05
eac9c5e
to
eb19033
Compare
I'm locking the conversation so as not to create unnecessary controversy. Use |
iZboxo
reviewed
Feb 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I know that message commands are no longer supported even by discord, but we are a framework that is mainly used for merging, so we should support this.
Other reasons:
This support will be so basic, we still prefer slash commands.
^ We can't support autocomplete but only choices in message command handler.
Status and versioning classification:
Wait for