Skip to content

Commit

Permalink
test: update postmortem test with v12 constants
Browse files Browse the repository at this point in the history
Ref: nodejs/llnode#330

PR-URL: nodejs#31391
Refs: nodejs/llnode#330
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
mmarchini authored and Trott committed Jan 18, 2020
1 parent 7864c53 commit b318926
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/v8-updates/test-postmortem-metadata.js
Expand Up @@ -48,7 +48,8 @@ const missing = getExpectedSymbols().filter((symbol) => {
return !symbols.includes(symbol);
});

assert.strictEqual(missing.length, 0, `Missing constants: ${missing}`);
assert.strictEqual(missing.length, 0,
`Missing constants: \n${missing.join('\n')}`);

// This is only a function so that the long list of expected symbols can be
// pushed to the bottom of the file for improved readability.
Expand All @@ -58,6 +59,7 @@ function getExpectedSymbols() {
// should only consist of postmortem constants, and some of them can be
// relatively long.
/* eslint-disable max-len */
'v8dbg_class_DescriptorArray__header_size__uintptr_t',
'v8dbg_bit_field3_is_dictionary_map_shift',
'v8dbg_bit_field3_number_of_own_descriptors_shift',
'v8dbg_class_Code__instruction_size__int',
Expand Down

0 comments on commit b318926

Please sign in to comment.