The divergent specifier hazard and how to prevent or avoid it #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
force-pushed
the
exports-conditions-warnings
branch
2 times, most recently
from
c85bdf4
to
681d006
Compare
GeoffreyBooth
force-pushed
the
exports-conditions-warnings
branch
from
681d006
to
fb7500b
Compare
guybedford
reviewed
Oct 20, 2019
GeoffreyBooth
force-pushed
the
exports-conditions-warnings
branch
from
973c6cf
to
d468c07
Compare
ljharb
reviewed
Oct 21, 2019
|
Please refer to nodejs#30051 going forward. These suggestions are good ones, I’ll update the branch when I get a chance; you don’t need to repeat the comments on the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/GeoffreyBooth/node/pull/2/files?short_path=8e67f40#diff-8e67f407bc32a0569e25d7ecaff6e494