Drop import of extensionless #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wrong target repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for
importof extensionless files, per discussion in nodejs#31388 (comment). Such support was only added last month, in nodejs#31021, and 13.6.0. This PR reverts that one, and updates the docs to make it clear that the prior support for extensionless files was limited to main entry points.Whether we want to go further and drop support for extensionless ESM main entry points is an open question, and one that I think should probably get its own PR. I assume that that support was there as part of supporting bin files, so if we remove it we’ll need some other equivalent solution.
I also appreciate that nodejs#31021 had its own purpose in enabling WASI entry points, and so reverting it will mean that we need a new solution for that use case as well. I don’t think this PR needs to wait on that solution, however, since WASI entry points aren’t supported yet in Node.