Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress address in bind log statement if it is 0.0.0.0 #4160

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Sep 29, 2023

shows [14:07:59 INFO] Started Geyser on :19132

best i can do without modifying all the locale strings

Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good lil change, I like it

@Konicai Konicai added the PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README label Sep 29, 2023
@Camotoy
Copy link
Member

Camotoy commented Sep 29, 2023

I'd rather not half-bake this approach. Let's make a new locale string? Started Geyser on UDP port {0}.

Adding UDP will probably be helpful.

@Konicai
Copy link
Member Author

Konicai commented Sep 29, 2023

lol simply adding a new string didn't even come to mind.

we could modify the current locale string to just take one argument though, and slap a (UDP) at the end. it would be kind of nice to have only one for the sake of simplicity and less translation. i would have to modify them all at once so that we wouldn't get string resolution errors, i think.

@Konicai Konicai added the PR: On hold When a PR is on hold like if it requires a dependency to be updated first label Sep 29, 2023
onebeastchris added a commit to onebeastchris/languages that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README PR: On hold When a PR is on hold like if it requires a dependency to be updated first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants